Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DeepSpeed <0.7.0 #13859

Merged
merged 7 commits into from
Jul 28, 2022
Merged

Support DeepSpeed <0.7.0 #13859

merged 7 commits into from
Jul 28, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jul 26, 2022

What does this PR do?

Fixes #13191

Does your PR introduce any breaking changes? If yes, please list them.

Not by us, but DeepSpeed>=0.6.5 is not supported in Lite.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @awaelchli @rohitgr7 @akihironitta @Borda

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 26, 2022
@awaelchli awaelchli mentioned this pull request Jul 27, 2022
11 tasks
@carmocca carmocca changed the title [WIP] Upgrade DeepSpeed Support DeepSpeed <0.7.0 Jul 27, 2022
@carmocca carmocca marked this pull request as ready for review July 27, 2022 17:00
@carmocca carmocca added this to the pl:1.7 milestone Jul 27, 2022
@carmocca carmocca enabled auto-merge (squash) July 27, 2022 17:02
@mergify mergify bot added the ready PRs ready to be merged label Jul 28, 2022
@carmocca carmocca merged commit 406cea7 into master Jul 28, 2022
@carmocca carmocca deleted the ci/upgrade-deepspeed branch July 28, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: deepspeed tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update deepspeed requirement from <0.6.0 to <0.7.0
4 participants